internal/resources/applications/application.go (1)

340-362: Consider adding deduplication logic for idempotency.

The mutator appends NODE_IP to all containers without checking if it already exists. While Kubernetes will use the last value if duplicates exist (making this non-critical), adding a check would improve idempotency:

 func (a Application) withNodeIP(ctx core.Context) core.ObjectMutator[*appsv1.Deployment] {
 	return func(deployment *appsv1.Deployment) error {
 		nodeIPEnvVar := corev1.EnvVar{
 			Name: "NODE_IP",
 			ValueFrom: &corev1.EnvVarSource{
 				FieldRef: &corev1.ObjectFieldSelector{
 					FieldPath: "status.hostIP",
 				},
 			},
 		}
 
 		for i, container := range deployment.Spec.Template.Spec.InitContainers {
+			// Skip if NODE_IP already exists
+			exists := false
+			for _, env := range container.Env {
+				if env.Name == "NODE_IP" {
+					exists = true
+					break
+				}
+			}
+			if !exists {
 				container.Env = append(container.Env, nodeIPEnvVar)
-			deployment.Spec.Template.Spec.InitContainers[i] = container
+				deployment.Spec.Template.Spec.InitContainers[i] = container
+			}
 		}
 		// Similar logic for Containers...
 
 		return nil
 	}
 }

Note: This pattern also applies to withEELicence and withJsonLogging mutators, suggesting a broader codebase pattern that could be improved in a separate refactoring effort.

internal/resources/applications/application_test.go (1)

66-204: Consider adding a test case for duplicate injection scenario.

To ensure idempotent behavior, consider adding a test case that verifies the mutator's behavior when NODE_IP already exists:

{
	name: "deployment with existing NODE_IP",
	deployment: &appsv1.Deployment{
		Spec: appsv1.DeploymentSpec{
			Template: v1.PodTemplateSpec{
				Spec: v1.PodSpec{
					Containers: []v1.Container{
						{
							Name:  "main",
							Image: "test:latest",
							Env: []v1.EnvVar{
								{Name: "NODE_IP", Value: "existing_value"},
							},
						},
					},
				},
			},
		},
	},
},

This would help verify whether duplicates are created or if the existing value is preserved/overwritten.

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.